Implementation notes: amd64, samba, crypto_dh/hecfp128bk

Compiler output

io.c: io.c:352:14: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
io.c:                 if((buf[i] == -1)){
io.c:                     ~~~~~~~^~~~~
io.c: io.c:352:14: note: remove extraneous parentheses around the comparison to silence this warning
io.c:                 if((buf[i] == -1)){
io.c:                    ~       ^    ~
io.c: io.c:352:14: note: use '=' to turn this equality comparison into an assignment
io.c:                 if((buf[i] == -1)){
io.c:                            ^~
io.c:                            =
io.c: io.c:379:14: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
io.c:                 if((buf[i] == -1)){
io.c:                     ~~~~~~~^~~~~
io.c: io.c:379:14: note: remove extraneous parentheses around the comparison to silence this warning
io.c:                 if((buf[i] == -1)){
io.c:                    ~       ^    ~
io.c: io.c:379:14: note: use '=' to turn this equality comparison into an assignment
io.c:                 if((buf[i] == -1)){
io.c:                            ^~
io.c:                            =
io.c: 2 warnings generated.

Namespace violations

alloc.o crympix B
alloc.o crympix_init T
alloc.o crympix_kill T
alloc.o kn_alloc T
alloc.o kn_flush T
alloc.o kn_flush_fast T
alloc.o kn_free T
alloc.o kn_free_fast T
alloc.o kn_init T
alloc.o kn_init_fast T
alloc.o kn_kill T
alloc.o kn_kill_fast T
alloc.o kn_release T
array_lo.o man_compare T
array_lo.o man_compare_1 T
array_lo.o man_convert_base T
array_lo.o man_convert_word T
array_lo.o man_normalize_right T
array_lo.o man_shift_left T
array_lo.o man_shift_left_experimental T
array_lo.o man_shift_right T
divisor.o hec_fp_aadd_2e128mc_g2i T
divisor.o hec_fp_add_2e128mc_g2i T
divisor.o hec_fp_cpy_2e128mc_g2i T
divisor.o hec_fp_dbl_2e128mc_g2i T
divisor.o hec_fp_dbl_2e128mc_g2i_a2is0_a3is0 T
divisor.o hec_fp_madd_2e128mc_g2i T
divisor.o hec_fp_neg_2e128mc_g2i T
divisor_aadd.o hec_fp_aadd_2e128mc_g2i_x8664_asm T
divisor_add.o hec_fp_add_2e128mc_g2i_x8664_asm T
divisor_dbl.o hec_fp_dbl_2e128mc_g2i_x8664_asm T
divisor_dbl_a2is0_a3is0.o hec_fp_dbl_2e128mc_g2i_a2is0_a3is0_x8664_asm T
divisor_madd.o hec_fp_madd_2e128mc_g2i_x8664_asm T
error.o kn_exit T
error.o kn_memcheck T
error.o kn_warn T
fp_2e128mc.o fp_add_1_2e128mc_x8664 T
fp_2e128mc.o fp_add_2e128mc_x8664 T
fp_2e128mc.o fp_cpy_2e128mc_x8664 T
fp_2e128mc.o fp_dv2_2e128mc_x8664 T
fp_2e128mc.o fp_ml2_2e128mc_x8664 T
fp_2e128mc.o fp_mld_2e128mc_x8664 T
fp_2e128mc.o fp_mul_2e128mc_x8664 T
fp_2e128mc.o fp_set_1_2e128mc_x8664 T
fp_2e128mc.o fp_sqr_2e128mc_x8664 T
fp_2e128mc.o fp_sub_2_2e128mc_x8664 T
fp_2e128mc.o fp_sub_2e128mc_x8664 T
fp_2e128mc_x8664.o fp_inv_2e128mc_x8664 T
fpx.o find_nextwindow T
fpx.o fp_cnt_bits T
integer_hi_stack.o mi_add_1_stack T
integer_hi_stack.o mi_add_stack T
integer_hi_stack.o mi_clone_stack T
integer_hi_stack.o mi_compare_abs_1_stack T
integer_hi_stack.o mi_compare_abs_stack T
integer_hi_stack.o mi_compare_stack T
integer_hi_stack.o mi_div_1_stack T
integer_hi_stack.o mi_div_q_r_stack T
integer_hi_stack.o mi_div_q_stack T
integer_hi_stack.o mi_div_stack T
integer_hi_stack.o mi_exp_stack T
integer_hi_stack.o mi_gcd_stack T
integer_hi_stack.o mi_gcdx_stack T
integer_hi_stack.o mi_init_stack T
integer_hi_stack.o mi_io_fprint_ln_stack T
integer_hi_stack.o mi_io_fprint_stack T
integer_hi_stack.o mi_io_fscan_stack T
integer_hi_stack.o mi_io_scan_stack T
integer_hi_stack.o mi_io_sprint_stack T
integer_hi_stack.o mi_io_sscan_stack T
integer_hi_stack.o mi_lcm_stack T
integer_hi_stack.o mi_mod_stack T
integer_hi_stack.o mi_modadd_stack T
integer_hi_stack.o mi_moddiv_stack T
integer_hi_stack.o mi_modexp_stack T
integer_hi_stack.o mi_modinv_stack T
integer_hi_stack.o mi_modmul_stack T
integer_hi_stack.o mi_modsub_stack T
integer_hi_stack.o mi_mul_1_stack T
integer_hi_stack.o mi_mul_stack T
integer_hi_stack.o mi_negate_stack T
integer_hi_stack.o mi_set_1_stack T
integer_hi_stack.o mi_sub_1_stack T
integer_hi_stack.o mi_sub_stack T
integer_lo.o min_compare T
integer_lo.o min_div_qr T
integer_lo.o min_find_nd T
integer_lo.o min_find_window T
integer_lo.o min_gcdx_lehmer T
integer_lo.o min_mul_basecase T
integer_lo.o min_mul_karatsuba T
integer_lo.o min_nres_prepare T
integer_lo.o min_nres_prepare2 T
integer_lo.o min_nres_redc T
integer_lo.o min_sqr_basecase T
integer_lo.o min_sqr_karatsuba T
io.o kn_io_fprint T
io.o kn_io_fscan T
io.o kn_io_sprint T
io.o kn_io_sscan T
rand.o kn_rand T
rand.o kn_srand T
smul_glv4.o hec_fp_smul_2e128mc_bk_glv4 T
test.o copyrightclaims T
test.o patentclaims T
test.o timingattacks T

Namespace violations

alloc.o crympix B
alloc.o crympix_init T
alloc.o crympix_kill T
alloc.o kn_alloc T
alloc.o kn_flush T
alloc.o kn_flush_fast T
alloc.o kn_free T
alloc.o kn_free_fast T
alloc.o kn_init T
alloc.o kn_init_fast T
alloc.o kn_kill T
alloc.o kn_kill_fast T
alloc.o kn_release T
array_lo.o man_compare T
array_lo.o man_compare_1 T
array_lo.o man_convert_base T
array_lo.o man_convert_word T
array_lo.o man_normalize_right T
array_lo.o man_shift_left T
array_lo.o man_shift_left_experimental T
array_lo.o man_shift_right T
divisor.o hec_fp_aadd_2e128mc_g2i T
divisor.o hec_fp_add_2e128mc_g2i T
divisor.o hec_fp_cpy_2e128mc_g2i T
divisor.o hec_fp_dbl_2e128mc_g2i T
divisor.o hec_fp_dbl_2e128mc_g2i_a2is0_a3is0 T
divisor.o hec_fp_madd_2e128mc_g2i T
divisor.o hec_fp_neg_2e128mc_g2i T
divisor_aadd.o hec_fp_aadd_2e128mc_g2i_x8664_asm T
divisor_add.o hec_fp_add_2e128mc_g2i_x8664_asm T
divisor_dbl.o hec_fp_dbl_2e128mc_g2i_x8664_asm T
divisor_dbl_a2is0_a3is0.o hec_fp_dbl_2e128mc_g2i_a2is0_a3is0_x8664_asm T
divisor_madd.o hec_fp_madd_2e128mc_g2i_x8664_asm T
error.o kn_exit T
error.o kn_memcheck T
error.o kn_warn T
fp_2e128mc.o fp_add_1_2e128mc_x8664 T
fp_2e128mc.o fp_add_2e128mc_x8664 T
fp_2e128mc.o fp_cpy_2e128mc_x8664 T
fp_2e128mc.o fp_dv2_2e128mc_x8664 T
fp_2e128mc.o fp_ml2_2e128mc_x8664 T
fp_2e128mc.o fp_mld_2e128mc_x8664 T
fp_2e128mc.o fp_mul_2e128mc_x8664 T
fp_2e128mc.o fp_set_1_2e128mc_x8664 T
fp_2e128mc.o fp_sqr_2e128mc_x8664 T
fp_2e128mc.o fp_sub_2_2e128mc_x8664 T
fp_2e128mc.o fp_sub_2e128mc_x8664 T
fp_2e128mc_x8664.o fp_inv_2e128mc_x8664 T
fpx.o find_nextwindow T
fpx.o fp_cnt_bits T
integer_hi_stack.o mi_add_1_stack T
integer_hi_stack.o mi_add_stack T
integer_hi_stack.o mi_clone_stack T
integer_hi_stack.o mi_compare_abs_1_stack T
integer_hi_stack.o mi_compare_abs_stack T
integer_hi_stack.o mi_compare_stack T
integer_hi_stack.o mi_div_1_stack T
integer_hi_stack.o mi_div_q_r_stack T
integer_hi_stack.o mi_div_q_stack T
integer_hi_stack.o mi_div_stack T
integer_hi_stack.o mi_exp_stack T
integer_hi_stack.o mi_gcd_stack T
integer_hi_stack.o mi_gcdx_stack T
integer_hi_stack.o mi_init_stack T
integer_hi_stack.o mi_io_fprint_ln_stack T
integer_hi_stack.o mi_io_fprint_stack T
integer_hi_stack.o mi_io_fscan_stack T
integer_hi_stack.o mi_io_scan_stack T
integer_hi_stack.o mi_io_sprint_stack T
integer_hi_stack.o mi_io_sscan_stack T
integer_hi_stack.o mi_lcm_stack T
integer_hi_stack.o mi_mod_stack T
integer_hi_stack.o mi_modadd_stack T
integer_hi_stack.o mi_moddiv_stack T
integer_hi_stack.o mi_modexp_stack T
integer_hi_stack.o mi_modinv_stack T
integer_hi_stack.o mi_modmul_stack T
integer_hi_stack.o mi_modsub_stack T
integer_hi_stack.o mi_mul_1_stack T
integer_hi_stack.o mi_mul_stack T
integer_hi_stack.o mi_negate_stack T
integer_hi_stack.o mi_set_1_stack T
integer_hi_stack.o mi_sub_1_stack T
integer_hi_stack.o mi_sub_stack T
integer_lo.o min_compare T
integer_lo.o min_div_qr T
integer_lo.o min_find_nd T
integer_lo.o min_find_window T
integer_lo.o min_gcdx_lehmer T
integer_lo.o min_mul_basecase T
integer_lo.o min_mul_karatsuba T
integer_lo.o min_nres_prepare T
integer_lo.o min_nres_prepare2 T
integer_lo.o min_nres_redc T
integer_lo.o min_sqr_basecase T
integer_lo.o min_sqr_karatsuba T
io.o kn_io_fprint T
io.o kn_io_fscan T
io.o kn_io_sprint T
io.o kn_io_sscan T
rand.o kn_rand T
rand.o kn_srand T
smul.o hec_fp_smul_2e128mc_g2i T
smul.o hec_fp_smulcached_2e128mc_g2i T
smul.o hec_fp_smulcached_2e128mc_g2i_a2is0_a3is0 T
smul_glv4.o hec_fp_smul_2e128mc_bk_glv4 T
test.o copyrightclaims T
test.o patentclaims T
test.o timingattacks T