Implementation notes: amd64, rumba5, crypto_kem/edonk128ref

Compiler output

dec.c: dec.c:710:89: warning: for loop has empty body [-Wempty-body]
dec.c:                 for(i=0; i<(1<<(ErrorBasisDimension+1))+2; i++) Kclear(allcandidates[i]);
dec.c:                                                                                         ^
dec.c: dec.c:710:89: note: put the semicolon on a separate line to silence this warning
dec.c: dec.c:590:76: warning: for loop has empty body [-Wempty-body]
dec.c:     for(i=0; i<(1<<(ErrorBasisDimension+1))+2; i++) Kinit(allcandidates[i]);
dec.c:                                                                            ^
dec.c: dec.c:590:76: note: put the semicolon on a separate line to silence this warning
dec.c: dec.c:595:56: warning: for loop has empty body [-Wempty-body]
dec.c:     for(i=0; i<NrColumns; i++) Kinit(Ciphertext.cph[i]);
dec.c:                                                        ^
dec.c: dec.c:595:56: note: put the semicolon on a separate line to silence this warning
dec.c: 3 warnings generated.
mpfq_2_128.c: mpfq_2_128.c:154:35: warning: passing 'char *' to parameter of type 'const unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
mpfq_2_128.c:         int ret = mpn_set_str(zz, tmp, len, k->io_type);
mpfq_2_128.c:                                   ^~~
mpfq_2_128.c: .../supercop-data/rumba5/amd64/include/gmp.h:1595:68: note: passing argument to parameter here
mpfq_2_128.c: __GMP_DECLSPEC mp_size_t mpn_set_str (mp_ptr, const unsigned char *, size_t, int);
mpfq_2_128.c:                                                                    ^
mpfq_2_128.c: 1 warning generated.

Compiler output

mpfq_2_128.c: mpfq_2_128.c: In function 'mpfq_2_128_sscan':
mpfq_2_128.c: mpfq_2_128.c:154:35: warning: pointer targets in passing argument 2 of '__gmpn_set_str' differ in signedness [-Wpointer-sign]
mpfq_2_128.c:   154 |         int ret = mpn_set_str(zz, tmp, len, k->io_type);
mpfq_2_128.c:       |                                   ^~~
mpfq_2_128.c:       |                                   |
mpfq_2_128.c:       |                                   char *
mpfq_2_128.c: In file included from mpfq.h:6,
mpfq_2_128.c:                  from mpfq_2_128.h:6,
mpfq_2_128.c:                  from mpfq_2_128.c:3:
mpfq_2_128.c: .../supercop-data/rumba5/amd64/include/gmp.h:1595:47: note: expected 'const unsigned char *' but argument is of type 'char *'
mpfq_2_128.c:  1595 | __GMP_DECLSPEC mp_size_t mpn_set_str (mp_ptr, const unsigned char *, size_t, int);
mpfq_2_128.c:       |                                               ^~~~~~~~~~~~~~~~~~~~~

Namespace violations

dec.o addcandidate T
dec.o checkhash T
enc.o K B
gmp_export.o gmp_export T
gmp_import.o gmp_import T
mpfq_2_128.o mpfq_2_128_asprint T
mpfq_2_128.o mpfq_2_128_fprint T
mpfq_2_128.o mpfq_2_128_fscan T
mpfq_2_128.o mpfq_2_128_sscan T
rng.o AES256_ECB T
rng.o DRBG_ctx B
rng.o handleErrors T
rng.o seedexpander T
rng.o seedexpander_init T