Implementation notes: amd64, hertz, crypto_sort/int32

Test failure

error 111

Compiler output

api.cpp: In file included from api.cpp:3:
api.cpp: In file included from ./aspas.h:204:
api.cpp: In file included from ./aspas.tcc:31:
api.cpp: In file included from ./sorter.h:120:
api.cpp: In file included from ./sorter_avx2.tcc:27:
api.cpp: ./util/extintrin.h:37:13: warning: unused variable 'max1' [-Wunused-variable]
api.cpp:    37 |     __m128i max1, min1, max2, min2;
api.cpp:       |             ^~~~
api.cpp: ./util/extintrin.h:37:25: warning: unused variable 'max2' [-Wunused-variable]
api.cpp:    37 |     __m128i max1, min1, max2, min2;
api.cpp:       |                         ^~~~
api.cpp: ./util/extintrin.h:53:19: warning: unused variable 'min1' [-Wunused-variable]
api.cpp:    53 |     __m128i max1, min1, max2, min2;
api.cpp:       |                   ^~~~
api.cpp: ./util/extintrin.h:53:31: warning: unused variable 'min2' [-Wunused-variable]
api.cpp:    53 |     __m128i max1, min1, max2, min2;
api.cpp:       |                               ^~~~
api.cpp: In file included from api.cpp:3:
api.cpp: In file included from ./aspas.h:204:
api.cpp: In file included from ./aspas.tcc:32:
api.cpp: In file included from ./merger.h:64:
api.cpp: ./merger.tcc:187:17: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
api.cpp:   187 |         if (num & 1 == 1)
api.cpp:       |                 ^~~~~~~~
api.cpp: ./merger.tcc:187:17: note: place parentheses around the '==' expression to silence this warning
api.cpp: ...

Compiler output

api.cpp: In file included from sorter_avx2.tcc:27,
api.cpp:                  from sorter.h:120,
api.cpp:                  from aspas.tcc:31,
api.cpp:                  from aspas.h:204,
api.cpp:                  from api.cpp:3:
api.cpp: util/extintrin.h: In function '__m256i util::_my_mm256_min_epi32(__m256i, __m256i)':
api.cpp: util/extintrin.h:37:13: warning: unused variable 'max1' [-Wunused-variable]
api.cpp:    37 |     __m128i max1, min1, max2, min2;
api.cpp:       |             ^~~~
api.cpp: util/extintrin.h:37:25: warning: unused variable 'max2' [-Wunused-variable]
api.cpp:    37 |     __m128i max1, min1, max2, min2;
api.cpp:       |                         ^~~~
api.cpp: util/extintrin.h: In function '__m256i util::_my_mm256_max_epi32(__m256i, __m256i)':
api.cpp: util/extintrin.h:53:19: warning: unused variable 'min1' [-Wunused-variable]
api.cpp:    53 |     __m128i max1, min1, max2, min2;
api.cpp:       |                   ^~~~
api.cpp: util/extintrin.h:53:31: warning: unused variable 'min2' [-Wunused-variable]
api.cpp:    53 |     __m128i max1, min1, max2, min2;
api.cpp:       |                               ^~~~
api.cpp: sorter_avx2.tcc: At global scope:
api.cpp: sorter_avx2.tcc:96:47: warning: ignoring attributes on template argument '__m256' [-Wignored-attributes]
api.cpp:    96 | typename std::enable_if<std::is_same<T, __m256>::value>::type
api.cpp:       |                                               ^
api.cpp: sorter_avx2.tcc:150:47: warning: ignoring attributes on template argument '__m256' [-Wignored-attributes]
api.cpp:   150 | typename std::enable_if<std::is_same<T, __m256>::value>::type
api.cpp: ...

Compiler output

sort.c: sort.c:133:17: warning: passing 'int32[n]' (aka 'int[n]') to parameter of type 'uint32 *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Wpointer-sign]
sort.c:   133 |   RadixSort11(x,y,n);
sort.c:       |                 ^
sort.c: sort.c:47:48: note: passing argument to parameter 'sort' here
sort.c:    47 | static void RadixSort11(uint32 *array, uint32 *sort, uint32 elements)
sort.c:       |                                                ^
sort.c: 1 warning generated.

Compiler output

sort.c: sort.c: In function 'crypto_sort_int32_herf_timingleaks':
sort.c: sort.c:133:17: warning: pointer targets in passing argument 2 of 'RadixSort11' differ in signedness [-Wpointer-sign]
sort.c:   133 |   RadixSort11(x,y,n);
sort.c:       |                 ^
sort.c:       |                 |
sort.c:       |                 int32 * {aka int *}
sort.c: sort.c:47:48: note: expected 'uint32 *' {aka 'unsigned int *'} but argument is of type 'int32 *' {aka 'int *'}
sort.c:    47 | static void RadixSort11(uint32 *array, uint32 *sort, uint32 elements)
sort.c:       |                                        ~~~~~~~~^~~~

Compiler output

api.cpp: api.cpp:22:42: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
api.cpp:    22 |   __attribute__((aligned(32))) int32_t y[n];
api.cpp:       |                                          ^
api.cpp: api.cpp:22:42: note: function parameter 'n' with unknown value cannot be used in a constant expression
api.cpp: api.cpp:8:40: note: declared here
api.cpp:     8 | void crypto_sort(void *array,long long n)
api.cpp:       |                                        ^
api.cpp: 1 warning generated.

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x10A786
   at 0x...: core (try-anything.c:61)
   by 0x...: salsa20 (try-anything.c:101)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: myrandom (try-anything.c:132)
   by 0x...: test (try.c:104)
   by 0x...: main (try-anything.c:345)

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x10B2A4
   at 0x...: salsa20 (try-anything.c:90)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: input_prepare (try-anything.c:162)
   by 0x...: test (try.c:107)
   by 0x...: main (try-anything.c:345)

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x109932
   at 0x...: core (try-anything.c:64)
   by 0x...: salsa20 (try-anything.c:101)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: myrandom (try-anything.c:132)
   by 0x...: test (try.c:104)
   by 0x...: main (try-anything.c:345)

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x109997
   at 0x...: core (try-anything.c:68)
   by 0x...: salsa20.part.0 (try-anything.c:101)
   by 0x...: salsa20 (try-anything.c:85)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: myrandom (try-anything.c:132)
   by 0x...: test (try.c:104)
   by 0x...: main (try-anything.c:345)

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x1099EC
   at 0x...: core (try-anything.c:64)
   by 0x...: salsa20 (try-anything.c:101)
   by 0x...: salsa20 (try-anything.c:81)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: myrandom (try-anything.c:132)
   by 0x...: test (try.c:104)
   by 0x...: main (try-anything.c:345)

TIMECOP error (can be valgrind bug)

error 111

Process terminating with default action of signal 4 (SIGILL)
 Illegal opcode at address 0x109879
   at 0x...: core (try-anything.c:64)
   by 0x...: salsa20.part.0 (try-anything.c:101)
   by 0x...: salsa20 (try-anything.c:85)
   by 0x...: testvector (try-anything.c:124)
   by 0x...: myrandom (try-anything.c:132)
   by 0x...: test (try.c:104)
   by 0x...: main (try-anything.c:345)