Implementation notes: amd64, hertz, crypto_encrypt/mceliece

Compiler output

misc.c: misc.c:6:35: warning: passing 'char *' to parameter of type 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
misc.c:     6 | int u8rnd() { char c; randombytes(&c,1); return 255 & (int) c; }
misc.c:       |                                   ^~
misc.c: .../supercop-data/hertz/amd64/include/randombytes.h:8:40: note: passing argument to parameter here
misc.c:     8 | extern void randombytes(unsigned char *,unsigned long long);
misc.c:       |                                        ^
misc.c: 1 warning generated.

Compiler output

misc.c: misc.c: In function 'u8rnd':
misc.c: misc.c:6:35: warning: pointer targets in passing argument 1 of 'randombytes' differ in signedness [-Wpointer-sign]
misc.c:     6 | int u8rnd() { char c; randombytes(&c,1); return 255 & (int) c; }
misc.c:       |                                   ^~
misc.c:       |                                   |
misc.c:       |                                   char *
misc.c: In file included from misc.c:3:
misc.c: .../supercop-data/hertz/amd64/include/randombytes.h:8:25: note: expected 'unsigned char *' but argument is of type 'char *'
misc.c:     8 | extern void randombytes(unsigned char *,unsigned long long);
misc.c:       |                         ^~~~~~~~~~~~~~~

Namespace violations

decrypt.o L B
decrypt.o coeffs B
decrypt.o decode T
decrypt.o g B
decrypt.o shortplaintext T
decrypt.o sk_free T
decrypt.o sk_from_string T
decrypt.o sqrtmod B
decrypt.o syndrome T
encrypt.o encryp_bloc T
encrypt.o pk_from_string T
encrypt.o shortciphertext T
encrypt.o vec_concat T
gf.o gf_exp B
gf.o gf_init T
gf.o gf_init_exp T
gf.o gf_init_log T
gf.o gf_log B
gf.o gf_pow T
gf.o gf_rand T
gf.o init_done B
keypair.o gop_supr T
keypair.o key_genmat T
mat.o mat_copy T
mat.o mat_free T
mat.o mat_ini T
mat.o mat_ini_from_string T
mat.o mat_mul T
mat.o mat_rowxor T
mat.o mat_rref T
mat.o mat_vec_mul T
misc.o bino D
misc.o buf B
misc.o buf_size B
misc.o fill_buf T
misc.o pick_er T
misc.o rnd T
misc.o u8rnd T
misc.o update_rnd T
poly.o poly_alloc T
poly.o poly_alloc_from_string T
poly.o poly_calcule_deg T
poly.o poly_copy T
poly.o poly_degppf T
poly.o poly_eeaux T
poly.o poly_eval T
poly.o poly_eval_aux T
poly.o poly_free T
poly.o poly_gcd T
poly.o poly_gcd_aux T
poly.o poly_mul T
poly.o poly_randgen_irred T
poly.o poly_rem T
poly.o poly_set T
poly.o poly_set_to_zero T
poly.o poly_shiftmod T
poly.o poly_sqmod T
poly.o poly_sqmod_init T
poly.o poly_sqrtmod_init T
poly.o poly_syndrome_init T