Implementation notes: amd64, hertz, crypto_aead/twine80n6t4clocv3

Compiler output

encrypt.c: encrypt.c:68:2: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
encrypt.c:    68 |         return RETURN_SUCCESS;
encrypt.c:       |         ^
encrypt.c: encrypt.c:63:5: note: previous statement is here
encrypt.c:    63 |     for(i = 0; i < CRYPTO_ABYTES; i++)
encrypt.c:       |     ^
encrypt.c: 1 warning generated.

Compiler output

encrypt.c: encrypt.c: In function 'crypto_aead_twine80n6t4clocv3_ref_timingleaks_decrypt':
encrypt.c: encrypt.c:63:5: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
encrypt.c:    63 |     for(i = 0; i < CRYPTO_ABYTES; i++)
encrypt.c:       |     ^~~
encrypt.c: encrypt.c:68:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
encrypt.c:    68 |         return RETURN_SUCCESS;
encrypt.c:       |         ^~~~~~
twine.c: twine.c: In function 'Keyschedule':
twine.c: twine.c:493:17: warning: 'Keyschedule128' reading 32 bytes from a region of size 16 [-Wstringop-overread]
twine.c:   493 |                 Keyschedule128(sk);
twine.c:       |                 ^~~~~~~~~~~~~~~~~~
twine.c: twine.c:493:17: note: referencing argument 1 of type 'const uint8[32]' {aka 'const unsigned char[32]'}
twine.c: twine.c:359:6: note: in a call to function 'Keyschedule128'
twine.c:   359 | void Keyschedule128(const uint8 sk[128/4])
twine.c:       |      ^~~~~~~~~~~~~~

Compiler output

cloc.c: cloc.c:193:26: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion]
cloc.c:   193 |                 state = XORDQW(state, SHR(state, 8));
cloc.c:       |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
cloc.c: ./common.h:30:126: note: expanded from macro 'SHR'
cloc.c:    30 | #define SHR(x,n)        _mm_shuffle_epi8((x), _mm_set_epi8(127+(n), 126+(n), 125+(n), 124+(n), 123+(n), 122+(n), 121+(n), 120+(n), 119+(n), 118+(n), 117+(n), 116+(n), 115+(n), 114+(n), 113+(n), 112+(n))) // shift to the right
cloc.c:       |                                               ~~~~~~~~~~~~                                                                   ^
cloc.c: ./common.h:18:43: note: expanded from macro 'XORDQW'
cloc.c:    18 | #define XORDQW(x, y)            _mm_xor_si128((x), (y))
cloc.c:       |                                                     ^
cloc.c: cloc.c:193:26: warning: implicit conversion from 'int' to 'char' changes value from 129 to -127 [-Wconstant-conversion]
cloc.c:   193 |                 state = XORDQW(state, SHR(state, 8));
cloc.c:       |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
cloc.c: ./common.h:30:117: note: expanded from macro 'SHR'
cloc.c:    30 | #define SHR(x,n)        _mm_shuffle_epi8((x), _mm_set_epi8(127+(n), 126+(n), 125+(n), 124+(n), 123+(n), 122+(n), 121+(n), 120+(n), 119+(n), 118+(n), 117+(n), 116+(n), 115+(n), 114+(n), 113+(n), 112+(n))) // shift to the right
cloc.c:       |                                               ~~~~~~~~~~~~                                                          ^
cloc.c: ./common.h:18:43: note: expanded from macro 'XORDQW'
cloc.c:    18 | #define XORDQW(x, y)            _mm_xor_si128((x), (y))
cloc.c:       |                                                     ^
cloc.c: cloc.c:193:26: warning: implicit conversion from 'int' to 'char' changes value from 130 to -126 [-Wconstant-conversion]
cloc.c:   193 |                 state = XORDQW(state, SHR(state, 8));
cloc.c:       |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
cloc.c: ./common.h:30:108: note: expanded from macro 'SHR'
cloc.c:    30 | #define SHR(x,n)        _mm_shuffle_epi8((x), _mm_set_epi8(127+(n), 126+(n), 125+(n), 124+(n), 123+(n), 122+(n), 121+(n), 120+(n), 119+(n), 118+(n), 117+(n), 116+(n), 115+(n), 114+(n), 113+(n), 112+(n))) // shift to the right
cloc.c:       |                                               ~~~~~~~~~~~~                                                 ^
cloc.c: ./common.h:18:43: note: expanded from macro 'XORDQW'
cloc.c: ...

Compiler output

cloc.c: cloc.c: In function 'ae_decrypt':
cloc.c: cloc.c:227:16: warning: unused variable 'tmpState' [-Wunused-variable]
cloc.c:   227 |         dqword tmpState;
cloc.c:       |                ^~~~~~~~
encrypt.c: encrypt.c: In function 'crypto_aead_twine80n6t4clocv3_vperm_timingleaks_decrypt':
encrypt.c: encrypt.c:64:5: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
encrypt.c:    64 |     for(i = 0; i < CRYPTO_ABYTES; i++)
encrypt.c:       |     ^~~
encrypt.c: encrypt.c:69:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
encrypt.c:    69 |         return RETURN_SUCCESS;
encrypt.c:       |         ^~~~~~

Namespace violations

cloc.o ae_encrypt T
cloc.o ae_init T
cloc.o process_ad T
twine.o CON_H R
twine.o CON_L R
twine.o Decode T
twine.o Encode T
twine.o Keyschedule T
twine.o Keyschedule128 T
twine.o Keyschedule80 T
twine.o S R
twine.o ek B
twine.o pstate3 T
twine.o pswitch B
utils.o print_cxt T
utils.o pstate T
utils.o pstate2 T
utils.o xor_bytes T
utils.o xor_bytes2 T

Namespace violations

cloc.o CON_H R
cloc.o CON_L R
cloc.o S R
cloc.o TWINE80_Keyschedule T
cloc.o TWINE80_enc T
cloc.o TWINE_ROUND_SHUFFLE R
cloc.o ae_clear T
cloc.o ae_decrypt T
cloc.o ae_encrypt T
cloc.o ae_init T
cloc.o ek B
cloc.o lsbox B
cloc.o process_ad T
cloc.o rks B
cloc.o usbox B