Implementation notes: amd64, bolero, crypto_sign/sflashv2

Compiler output

keypair.c: keypair.c:10:18: warning: unused variable 'seed' [-Wunused-variable]
keypair.c:   unsigned char *seed;
keypair.c:                  ^
keypair.c: keypair.c:11:7: warning: unused variable 'length' [-Wunused-variable]
keypair.c:   int length;
keypair.c:       ^
keypair.c: 2 warnings generated.
lib_flash.c: lib_flash.c:409:50: warning: '/*' within block comment [-Wcomment]
lib_flash.c:         init_table_flash(CK->M,/*CK->I,*/CK->M1/*,CK->M2/* /*,CK->M3*/);
lib_flash.c:                                                         ^
lib_flash.c: lib_flash.c:409:53: warning: '/*' within block comment [-Wcomment]
lib_flash.c:         init_table_flash(CK->M,/*CK->I,*/CK->M1/*,CK->M2/* /*,CK->M3*/);
lib_flash.c:                                                            ^
lib_flash.c: lib_flash.c:690:3: warning: '/*' within block comment [-Wcomment]
lib_flash.c:                 /*mis <E0> la puissance 2^7^22 de tmp
lib_flash.c:                 ^
lib_flash.c: lib_flash.c:692:3: warning: '/*' within block comment [-Wcomment]
lib_flash.c:                 /*
lib_flash.c:                 ^
lib_flash.c: lib_flash.c:695:4: warning: '/*' within block comment [-Wcomment]
lib_flash.c:    /* inversion affine de S*/
lib_flash.c:    ^
lib_flash.c: lib_flash.c:726:14: warning: 'size' argument to memset is '0'; did you mean to transpose the last two arguments? [-Wmemset-transposed-args]
lib_flash.c:         memset(V,33,0);
lib_flash.c:                     ^
lib_flash.c: lib_flash.c:726:14: note: parenthesize the third argument to silence
lib_flash.c: lib_flash.c:783:14: warning: 'size' argument to memset is '0'; did you mean to transpose the last two arguments? [-Wmemset-transposed-args]
lib_flash.c:         memset(V,33,0);
lib_flash.c:                     ^
lib_flash.c: lib_flash.c:783:14: note: parenthesize the third argument to silence
lib_flash.c: lib_flash.c:809:6: warning: unused variable 'i' [-Wunused-variable]
lib_flash.c:         int i;
lib_flash.c: ...

Compiler output

keypair.c: keypair.c: In function 'crypto_sign_sflashv2_ref_timingleaks_keypair':
keypair.c: keypair.c:11:7: warning: unused variable 'length' [-Wunused-variable]
keypair.c:    11 |   int length;
keypair.c:       |       ^~~~~~
keypair.c: keypair.c:10:18: warning: unused variable 'seed' [-Wunused-variable]
keypair.c:    10 |   unsigned char *seed;
keypair.c:       |                  ^~~~
lib_flash.c: lib_flash.c:270:29: warning: argument 1 of type 'unsigned char[37][37][37]' with mismatched bound [-Warray-parameter=]
lib_flash.c:   270 | void priv_pub(unsigned char QUAD[37][37][37], unsigned char LIN[37][37], unsigned char CONS[37], unsigned char S1[37][37],unsigned char S2[37], unsigned char T1[37][37],unsigned char T2[37],  unsigned char M[16384])
lib_flash.c:       |               ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
lib_flash.c: In file included from lib_flash.c:6:
lib_flash.c: lib_flash.h:38:29: note: previously declared as 'unsigned char[26][37][37]'
lib_flash.c:    38 | void priv_pub(unsigned char QUAD[26][37][37], unsigned char LIN[26][37], unsigned char CONS[26],
lib_flash.c:       |               ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
lib_flash.c: lib_flash.c:270:61: warning: argument 2 of type 'unsigned char[37][37]' with mismatched bound [-Warray-parameter=]
lib_flash.c:   270 | void priv_pub(unsigned char QUAD[37][37][37], unsigned char LIN[37][37], unsigned char CONS[37], unsigned char S1[37][37],unsigned char S2[37], unsigned char T1[37][37],unsigned char T2[37],  unsigned char M[16384])
lib_flash.c:       |                                               ~~~~~~~~~~~~~~^~~~~~~~~~~
lib_flash.c: In file included from lib_flash.c:6:
lib_flash.c: lib_flash.h:38:61: note: previously declared as 'unsigned char[26][37]'
lib_flash.c:    38 | void priv_pub(unsigned char QUAD[26][37][37], unsigned char LIN[26][37], unsigned char CONS[26],
lib_flash.c:       |                                               ~~~~~~~~~~~~~~^~~~~~~~~~~
lib_flash.c: lib_flash.c:270:88: warning: argument 3 of type 'unsigned char[37]' with mismatched bound [-Warray-parameter=]
lib_flash.c:   270 | void priv_pub(unsigned char QUAD[37][37][37], unsigned char LIN[37][37], unsigned char CONS[37], unsigned char S1[37][37],unsigned char S2[37], unsigned char T1[37][37],unsigned char T2[37],  unsigned char M[16384])
lib_flash.c:       |                                                                          ~~~~~~~~~~~~~~^~~~~~~~
lib_flash.c: In file included from lib_flash.c:6:
lib_flash.c: lib_flash.h:38:88: note: previously declared as 'unsigned char[26]'
lib_flash.c:    38 | void priv_pub(unsigned char QUAD[26][37][37], unsigned char LIN[26][37], unsigned char CONS[26],
lib_flash.c:       |                                                                          ~~~~~~~~~~~~~~^~~~~~~~
lib_flash.c: lib_flash.c: In function 'Flash_build_complete_key':
lib_flash.c: lib_flash.c:409:57: warning: "/*" within comment [-Wcomment]
lib_flash.c:   409 |         init_table_flash(CK->M,/*CK->I,*/CK->M1/*,CK->M2/* /*,CK->M3*/);
lib_flash.c:       |
lib_flash.c: ...